litmuschaos / admission-controllers

Admission Controllers used in LitmusChaos
Apache License 2.0
7 stars 6 forks source link

(chore) Ease the process of adding mutliple validation of ChaosEngine #10

Closed rahulchheda closed 4 years ago

rahulchheda commented 4 years ago

Signed-off-by: Rahul M Chheda rchheda@infracloud.io

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

How does this PR help?

So, for example, a contributor wants to add a function for the validation of namespace.

Steps needed to be performed:

Checklist:

ksatchit commented 4 years ago

Looks good @rahulchheda . Wondering if we should rename this file to a more generic appFilterCheck over annotationCheck - considering we now have the option to skip appinfo completely OR run w/ annotationCheck disabled