Closed christopherfriedrich closed 4 years ago
I want to add some unit tests this time with regard to #2, but i'm unsure how to name the corresponding file webhook_test
or appFilterCheck_test
?
Hey @christopherfriedrich , I was thinking to follow up with an issue on that conversation, but thanks for understnding the context, and getting a PR out of it.
For tests, I think the betterway would be just add unit tests, for appFilterCheck.go
i.e appFilterCheck_test.go
. Let me know if you need any help for it.
Signed-off-by: christopherfriedrich christopher.friedrich@haw-hamburg.de
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #14Special notes for your reviewer:
Checklist:
documentation
tagbreaking-changes
tagrequires-upgrade
tag