litmuschaos / admission-controllers

Admission Controllers used in LitmusChaos
Apache License 2.0
7 stars 6 forks source link

Added Logic to check existence of Secrets for ChaosExperiments #18

Closed christopherfriedrich closed 4 years ago

christopherfriedrich commented 4 years ago

Signed-off-by: christopherfriedrich christopher.friedrich@haw-hamburg.de

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #14

Special notes for your reviewer:

Checklist:

christopherfriedrich commented 4 years ago

I want to add some unit tests this time with regard to #2, but i'm unsure how to name the corresponding file webhook_test or appFilterCheck_test ?

rahulchheda commented 4 years ago

Hey @christopherfriedrich , I was thinking to follow up with an issue on that conversation, but thanks for understnding the context, and getting a PR out of it. For tests, I think the betterway would be just add unit tests, for appFilterCheck.go i.e appFilterCheck_test.go. Let me know if you need any help for it.