enable ALL for TARGET_CONTAINER

MichaelMorrisEst commented 7 months ago

What this PR does / why we need it: Enables the user to specify ALL for TARGET_CONTAINERS to execute against all containers in the pods in parallel execution

Which issue this PR fixes Closes #682

Special notes for your reviewer:

Checklist:

[x] Fixes #
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] E2E run Required for the changes

MichaelMorrisEst commented 6 months ago

Hi @ispeakc0de

Yes, I have tested.

When I use a specific container name ("hello-world-2"), I see in the logs that specific container being targeted:

time="2024-03-04T00:11:23Z" level=info msg="Helper Name: container-kill"
time="2024-03-04T00:11:23Z" level=info msg="[PreReq]: Getting the ENV variables"
time="2024-03-04T00:11:23Z" level=info msg="Injecting chaos on target: {name: ahoy-hello-world-778f6696cb-sqfjp, namespace: litmus, container: hello-world-2}"
time="2024-03-04T00:11:23Z" level=info msg="[Info]: Details of application under chaos injection" RestartCountBefore=49 PodName=ahoy-hello-world-778f6696cb-sqfjp ContainerName=hello-world-2

When I use "ALL" for the container name, I see both the containers in the pod being selected:

time="2024-03-04T00:15:52Z" level=info msg="Helper Name: container-kill"
time="2024-03-04T00:15:52Z" level=info msg="[PreReq]: Getting the ENV variables"
time="2024-03-04T00:15:52Z" level=info msg="Injecting chaos on target: {name: ahoy-hello-world-778f6696cb-sqfjp, namespace: litmus, container: hello-world}"
time="2024-03-04T00:15:52Z" level=info msg="Injecting chaos on target: {name: ahoy-hello-world-778f6696cb-sqfjp, namespace: litmus, container: hello-world-2}"
time="2024-03-04T00:15:52Z" level=info msg="[Info]: Details of application under chaos injection" RestartCountBefore=0 PodName=ahoy-hello-world-778f6696cb-sqfjp ContainerName=hello-world
time="2024-03-04T00:15:52Z" level=info msg="[Info]: Details of application under chaos injection" RestartCountBefore=49 PodName=ahoy-hello-world-778f6696cb-sqfjp ContainerName=hello-world-2

neelanjan00 commented 6 months ago

@MichaelMorrisEst can you please rebase the branch?

MichaelMorrisEst commented 6 months ago

@MichaelMorrisEst can you please rebase the branch?

No problem @neelanjan00 , rebased there now

neelanjan00 commented 6 months ago

@ispeakc0de are we good to merge?

litmuschaos / litmus-go

enable ALL for TARGET_CONTAINER #683