search

litmuschaos / litmus-helm

Helm Charts for the Litmus Chaos Operator & CRDs
Apache License 2.0
46 stars 88 forks source link

refactor(litmus): adding "ns.svc.cluster.local" to urls #371

Open jlplasce opened 7 months ago

jlplasce commented 7 months ago

Adding full service fqdn to the end of service urls to assist with proxied environments

What this PR does / why we need it:

In proxied environments, you can get Litmus to operate properly by setting proxies in the environment args. However, the service names are hardcoded just to the service name itself without any FQDN (i.e. "http://litmus-server-service:9002/") which will inadvertently send the traffic through the Proxy. Typically, in these proxied environments you'd put "cluster.local" in the no_proxy setting so internal cluster traffic is not proxied - since the service names are not a full domain path, we run in to issues. This PR appends the standard ".svc.cluster.local" to the nginx pass URLs as well as the DB_SERVER urls so that connection to those services are caught by the no_proxy settings

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

uditgaurav commented 6 months ago

Hi @jlplasce, thank you for submitting the pull request! It appears there are some conflicts that likely stem from version bumps. Could you please take a moment to resolve these? If you need any assistance, feel free to reach out. Thanks!