Hook secret name mismatch + Helm dependencies issue

[pierluigilenoci]

I found two issues related to the hook secret.

1) In the litmus-agent chart, a secret is created with {{ include "subscriber.fullname" . }}-hook but it is referred to using {{ include "litmus-agent.fullname" . }}-hook.

2) If we set the values subscriber.enabled: false the litmus-agent chart fails to generate the manifest because the string subscriber.fullname is used in the main chart but is generated in the subchart.

Ref: https://github.com/litmuschaos/litmus-helm/blob/2e2d4165e147f534a6e6f359aff2051b294a6d5b/charts/litmus-agent/templates/secret.yaml#L5

[pierluigilenoci]

I presume this is also related to another issue

• https://github.com/litmuschaos/litmus/issues/4967

• 334