Closed aryan-bhokare closed 6 months ago
@aryan-bhokare have you tested the code in the local? if you have would you share ss or some example (otherwise i have to check it myself) Other than that i think we should follow this approach and add more checks. @SarthakJain26 @neelanjan00 what more checks we should add before committing other than linting and fmt?
I tried it in your code in a codespace but it is still letting me commit some empty lines.
can you try and tell after linking it with pre-commit hook in git like this?
ln -s ../../.pre-commit .git/hooks/pre-commit
i think this should work if you have already forked it, can you check it if its working?
I tried it in your code in a codespace but it is still letting me commit some empty lines.
can you try and tell after linking it with pre-commit hook in git like this?
ln -s ../../.pre-commit .git/hooks/pre-commit
i think this should work if you have already forked it, can you check it if its working?
Yeah I didn't try this step as it wasn't listed as a prerequisite in the description
Making Formatting Error
Result
closes #196
Changes Introduced:
build.yml
) to facilitate automated testing and pre-commit hook execution..github-workflow-script
) to extract specific steps from the workflow file that contain theCOMMIT_HOOKS
environment variable set to "pre-commit".Details:
build.yml
is triggered upon pull requests targeting the "master" branch.gofmt
check step is conditioned by the presence of theCOMMIT_HOOKS
environment variable set to "pre-commit".COMMIT_HOOKS
variable are extracted and executed as part of the pre-commit hook integration process.Prerequisite:
use
ln -s ../../.pre-commit .git/hooks/pre-commit
to create a symbolic link namedpre-commit
in the.git/hooks
directory that points to the.pre-commit
.