search

litmuschaos / litmusctl

Command-Line tool to manage Litmuschaos's agent plane
Apache License 2.0
24 stars 45 forks source link

Refactor the update command #212

Closed shivam-Purohit closed 6 months ago

shivam-Purohit commented 7 months ago

Update command currently does not follow the command convention. we already have a version command we can just add this update command as subcommand for version command. It should look something like this litmusctl version update

or we can just add a flag for updating litmusctl version --update

this seems like a better approach for me

shivam-Purohit commented 7 months ago

I will refactor it for the update probe command

SarthakJain26 commented 7 months ago

Looks good to me. @kartikaysaxena any views on this?

milinddethe15 commented 7 months ago

Can I work on this?

shivam-Purohit commented 7 months ago

@milinddethe15 you can go ahead and raise a pr. Just mention this issue there.

kartikaysaxena commented 7 months ago

Sorry for being late here @SarthakJain26 , was busy recently, yeah I think it makes sense, would come up with a PR to enhance this feature.

shivam-Purohit commented 7 months ago

@kartikaysaxena you can raise a pr for that. Thank you!