timothy1ee
commented
11 years ago Sorry for the delayed feedback. I actually don't see the compose classes, did you push everything?
- The constraints for TweetCell look properly defined, nice work.
- The dynamic height is set up correctly. You're right that hardcoding the width isn't ideal, although in general that's a pain. Sometimes people will instantiate a single cell one time (and reuse that same cell for performance). I like creating a static method on the custom cell that knows how to calculate height. That way, that messy code can be tucked away in that class, and it's easier to reuse the cell. It's easier to share things like the font, etc.
Here's my checklist of things I'm looking at when I'm reviewing this project.
- Is the Objective-C code styling consistent with standards?
- Did you augment the API client with the methods for updating status, reply, retweet, favorite? Note that there is a separate endpoint for removing a retweet or favorite.
- Did you augment the Tweet model? Note that for the embedded user, you should instantiate a User object and have the User class do the deserialization, instead of navigating to user.screen_name in the Tweet model.
- Were the Auto Layout constraints correct for all the views?
- Was the navigation implemented correctly either manually or via segues?
- Was pull to refresh implemented?
- Was infinite scrolling implemented?
Apologies for not getting the favorites, retweet, and reply in. Additionally i'm getting weird animation on the composer view modal and when the user starts typing the composer. Other than that i think its feature complete.
/cc @nesquena @timothy1ee