littensy / charmed-icons

💝 Charming icon theme for Roblox projects on MacOS
https://marketplace.visualstudio.com/items?itemName=littensy.charmed-icons
MIT License
65 stars 8 forks source link

can we have support for "hidesExplorerArrows" #16

Open ctf0 opened 4 months ago

ctf0 commented 4 months ago

for how to, u can find it under https://github.com/littensy/charmed-icons/pull/7

littensy commented 4 months ago

The option in the PR wasn't functional when I tried it -- were you able to get it to work? I looked at other icon extensions that implement this option to make sure, and they seem to use JS/TS code to handle it (see https://github.com/material-extensions/vscode-material-icon-theme/commit/818e81d944c5cf4c8f4863b8f93ace67e3ddb357).

ctf0 commented 4 months ago

it did work on my app for the config its not really needed, but its away to get around the irritating unknown config key in vscode, the cmnd only needed to switch the setting on the fly which is optional.

anyway u can check the api for more info about that

littensy commented 4 months ago

Oh, I mean changing the setting on the fly isn't functional for me. I'll look into the API for configuration some time. It could be an issue with the extension debugger.

ctf0 commented 3 weeks ago

@littensy any updates on this ?