search

little-angry-clouds / kubernetes-binaries-managers

Kubernetes related binaries manager.
GNU General Public License v3.0
101 stars 11 forks source link

Handle auto-detected version strings with trailing information #38

Open TyBrown opened 1 year ago

TyBrown commented 1 year ago

Fixes #37

TyBrown commented 1 year ago

I fixed the golangci-lint stuff by upgrading the version, but there's a lot more failures than I can reasonably fix at this time, so I checked and ensured that I didn't introduce any new golangci-lint errors in the code I'm contributing in this PR compared to what is currently on master.

It also looks like the checks that GitHub Actions are running are against the base of the PR, so despite my fixing some of these issues, the checks are still failing in GitHub Actions. I believe this is due to the use of:

on: [pull_request_target]

instead of:

on: [pull_request]
TyBrown commented 1 year ago

@alexppg I hate to be a pest, but is there any chance of this getting reviewed/merged?