search

little-bear-labs / aws-utils

Apache License 2.0
56 stars 35 forks source link

Add JavaString to the vtl value mapper #128

Closed adamclerk closed 5 years ago

adamclerk commented 5 years ago

My second attempt at adding JavaString to the value mapper.

Please provide feedback.

schemaTest.test.js was throwing an error without the additional quotes in update-request.txt. I'm not sure if the bug is in new valueMapper or in the mapping template.

I also added some additional tests around the value mapper.

lightsofapollo commented 5 years ago

Approach LGTM here so far! Thanks for your contributions :)

adamclerk commented 5 years ago

@lightsofapollo @cbaron I'll leave it to you to merge. Also, when do you release updates to the npm package?

cbaron commented 5 years ago

Currently, it is done manually :) -- I would be open to changing that.

Just released:

+ @conduitvc/appsync-emulator-serverless@0.12.3