search

little-bear-labs / ipfs-chromium

19 stars 1 forks source link

lean V2 IPNS records #73

Closed John-LittleBearLabs closed 9 months ago

John-LittleBearLabs commented 10 months ago

IPNS-publishing software still fills out both V1 and V2 fields today. But that may change.

The spec now requires IPNS-validating software allow all V1 fields to be present if the V2 signature checks out.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 504 lines in your changes are missing coverage. Please review.

Comparison is base (479894a) 52.45% compared to head (4ef85ac) 59.79%. Report is 9 commits behind head on main.

Files Patch % Lines
library/src/ipfs_client/gw/gateway_request.cc 52.23% 64 Missing :warning:
library/src/ipfs_client/gw/requestor.cc 37.20% 54 Missing :warning:
.../src/libp2p/multi/multibase_codec/codecs/base16.cc 43.03% 45 Missing :warning:
library/src/ipfs_client/gw/requestor_pool.cc 0.00% 44 Missing :warning:
...brary/src/ipfs_client/gw/gateway_http_requestor.cc 64.91% 40 Missing :warning:
library/src/ipfs_client/gw/dnslink_requestor.cc 0.00% 37 Missing :warning:
library/src/ipfs_client/redirects.cc 79.73% 31 Missing :warning:
library/src/ipfs_client/ipns_record.cc 51.11% 22 Missing :warning:
library/src/ipfs_client/scheduler.cc 15.38% 22 Missing :warning:
...ibrary/src/ipfs_client/gw/terminating_requestor.cc 0.00% 18 Missing :warning:
... and 22 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #73 +/- ## ========================================== + Coverage 52.45% 59.79% +7.33% ========================================== Files 48 77 +29 Lines 2381 3477 +1096 ========================================== + Hits 1249 2079 +830 - Misses 1132 1398 +266 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.