little-bear-labs / ipfs-chromium

19 stars 1 forks source link

_redirects file's "to" field may be a full URL with different scheme #84

Closed John-LittleBearLabs closed 9 months ago

John-LittleBearLabs commented 9 months ago

Up to this point I had only been supporting redirects to IPFS paths (including those under /ipns/ namespace).

ipfs.tech , for example, has https:// URLs in its _redirects file.

This change is to make that work.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 317 lines in your changes are missing coverage. Please review.

Comparison is base (479894a) 52.45% compared to head (d31317d) 61.03%. Report is 13 commits behind head on main.

:exclamation: Current head d31317d differs from pull request most recent head cc404ce. Consider uploading reports for the commit cc404ce to get more accurate results

Files Patch % Lines
library/src/ipfs_client/gw/gateway_request.cc 59.78% 76 Missing :warning:
library/src/ipfs_client/all_inclusive.cc 0.00% 67 Missing :warning:
...brary/src/ipfs_client/gw/gateway_http_requestor.cc 57.25% 56 Missing :warning:
library/src/ipfs_client/gw/requestor.cc 41.89% 43 Missing :warning:
library/src/ipfs_client/gw/requestor_pool.cc 52.08% 23 Missing :warning:
library/src/ipfs_client/dag_cbor_value.cc 62.26% 20 Missing :warning:
library/include/vocab/html_escape.h 42.85% 8 Missing :warning:
library/src/ipfs_client/gateways.cc 76.47% 4 Missing :warning:
library/src/ipfs_client/gw/default_requestor.cc 81.25% 3 Missing :warning:
library/src/ipfs_client/gw/dnslink_requestor.cc 91.17% 3 Missing :warning:
... and 9 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #84 +/- ## ========================================== + Coverage 52.45% 61.03% +8.57% ========================================== Files 48 72 +24 Lines 2381 3131 +750 ========================================== + Hits 1249 1911 +662 - Misses 1132 1220 +88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.