little-brother / sqlite-gui

Lightweight SQLite editor for Windows
GNU General Public License v2.0
1.07k stars 51 forks source link

Constant crashing with 1.7.3 #117

Closed jungle-boogie closed 2 years ago

jungle-boogie commented 2 years ago

Hello,

With sqlite-gui 1.7.3, I am experiencing constant crashing when switching between editor tabs with my database.

I don't know if it's my database, my prefs.sqlite file, my SQL queries, but it's annoying, frustrating, and unexpected.

I'll switch to 1.7.2 to see if it happens left often there.

Thanks!

little-brother commented 2 years ago

Do you mean main top tabs or secondary result tabs? Please, let me know: 1.7.2 have the similar crushes or not.

P.S. I suspect changes relating to query highlighting.

jungle-boogie commented 2 years ago

The editor tabs are what I'm talking about.

P.S. I suspect changes relating to query highlighting.

Yeah, I think it's related to that. Seems to crash most often when I'm highlighting text from one editor tab to paste into another editor tab.

little-brother commented 2 years ago

The highligting is called when you switch between editor tabs too.

jungle-boogie commented 2 years ago

Version 1.7.2 is much more stable. I don't exactly know what part of highlighting causes the crashing in the later version.

little-brother commented 2 years ago

I have reproduce the issue on Win10 (but not under Win7). Simple Paste and undo by Ctrl + Z

{% for row in query("select * from books limit ?1", 3) %} select {{ quote(row.author) }}; {% endfor %}
{% for row in query("select * from books limit ?1", 3) %} select {{ quote(row.author) }}; {% endfor %}

will crash the app. It's a good start point to debug.

P.S. I forgot there were many refactoring changes with editors. Perhaps, highlighting is not to blame.

little-brother commented 2 years ago

Please check - sqlite-gui.1.7.3-x64-fix.zip

little-brother commented 2 years ago

I hope it fixed.

jungle-boogie commented 2 years ago

Thanks for releasing 1.7.4. I'll use that version for the next several days and see if things are better. I was on vacation with you made the patch, so I couldn't test it.