search

little-brother / sqlite-gui

Lightweight SQLite editor for Windows
GNU General Public License v2.0
1.07k stars 51 forks source link

Non-Rectangular Desktops (Right Click Behavior) #149

Closed wisnoskij closed 4 months ago

wisnoskij commented 7 months ago

Thank you for this amazing piece of software.

I encountered a really weird bug when using a vertical monitor stack next to single monitor such that my desktop space is non Rectangular.

Testing this behavior, it looks like the right click menu positioning gets confused and it ends up on the bottom of the desktop when I am right clicking on something that is outside of the main rectangular area.

See attached screenshot for example. Right clicking SESSIONS results in the right click menu being positioned incorrectly as shown, while R-clicking USERS results in the correct expected behavior.

These are both in the same monitor, so the app understands multiple monitors, but it looks like it expects a rectangular desktop area.

Screenshot 2023-11-22 140855

little-brother commented 7 months ago

Please check this version. P.S. On your screen I see how it will be good to have a dark theme, but it requires a lot of work :(

wisnoskij commented 7 months ago

Looks to be fixed!

Thank you little-brother, that was quick.

little-brother commented 7 months ago

It was just a solution check. The code have several places where it should be fixed. Also I found that in some cases a menu-button show a menu on a wrong position. I'll close the issue on the next release.

wisnoskij commented 7 months ago

Ah, good thing you reopened this. I discovered a new non-rectangular bug that is perhaps similar enough it should be in the same issue. If you open an "Edit Data" window outside of the main rectangular area, its windows buttons (close, max, min) will not function as well as dragging the window or resizing.

This prevents you from closing said window.

little-brother commented 7 months ago

I'm not sure about a relation between these issues. I'll try to repeat "non-functional buttons" later (I need to connect the second display and configurate it as vertical). Thanks for the report.

little-brother commented 4 months ago

I think the issue was mostly fixed. If problems arise, please open the issue again.