little-dude / netlink

netlink libraries for rust
Other
329 stars 89 forks source link

netlink-packet-sock-diag: Add TcpInfo parsing #211

Closed svart closed 2 years ago

little-dude commented 2 years ago

Ah sorry I meant to click "request changes", not approve. Seems that I can't change this =/ Done now. Just needed to re-review.

little-dude commented 2 years ago

Oh I just noticed that my comment didn't even go through, sorry @svart :(

I'd like to have this TcpInfo parsing but only with --features rich-nlas. See: https://github.com/little-dude/netlink/pull/199

svart commented 2 years ago

Let's make this opt-in via --features=rich-nlas just to be safe.

Ok! I will do it right after the holidays.

svart commented 2 years ago

Let's make this opt-in via --features=rich-nlas just to be safe.

Uploaded the patch. @little-dude could you please trigger the CI?

little-dude commented 2 years ago

Thanks a lot @svart :) I'll make a release now.

little-dude commented 2 years ago

Released 0.4.0!