little2s / NoChat

A lightweight chat UI framework for iOS.
591 stars 66 forks source link

Memory Leak or Retain Cycle #3

Closed mbalex99 closed 8 years ago

mbalex99 commented 8 years ago

It looks like there's a memory leak somewhere.

If you put

    deinit {
        print("Deinit Called")
    }

It never gets called in the demo project. There's some memory leak or strong retain cycle

little2s commented 8 years ago

Hi @mbalex99 , Memory problem is so bad, could you tell me this happening on which class? And more context about it?Thank you!

mbalex99 commented 8 years ago

It's happening in all the demo controllers

mbalex99 commented 8 years ago

You can out deinit in all demo controllers for TG, MM and SLK and find that deinit is not called.

little2s commented 8 years ago

Thanks for your feedback, there is a retain cycle between ChatViewController and ChatInputViewController, I have fixed it on this commit 141d924bc0aa2d05bdd267f2424691efd09c43df. @mbalex99

mbalex99 commented 8 years ago

Yes thank you so much!!! On Wed, Jun 15, 2016 at 7:20 PM Yinglun Duan notifications@github.com wrote:

Thanks for your feedback, there is a retain cycle between ChatViewController and ChatInputViewController, I have fixed it on this commit 141d924 https://github.com/little2s/NoChat/commit/141d924bc0aa2d05bdd267f2424691efd09c43df. @mbalex99 https://github.com/mbalex99

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/little2s/NoChat/issues/3#issuecomment-226371790, or mute the thread https://github.com/notifications/unsubscribe/ACFSMVsmkuV0_WCwdoSZgnAiw09mQOvYks5qMLLogaJpZM4I25EU .

Maximilian Alexander mbalex99@gmail.com http://blog.edenmsg.com

mbalex99 commented 8 years ago

Did you push to trunk for cocoapods or should I use this git branch?

little2s commented 8 years ago

This issue happened on Demo project, all of the pods need not to be changed. @mbalex99

mbalex99 commented 8 years ago

Ah I'm sorry I realized just now thank you!