This PR aims to consume split-diff's new service API for diffing 2 editors.
Benefits
Reduce amount of code in git-time-machine that was necessary to get split-diff working.
Installs split-diff as a package so user can tweak settings via Atom settings view.
The version of split-diff will stay up to date and user will get all new updates/bug fixes for it just like any other package.
Closes #71, #108, #110, #111, and #119
Things to note
Added new node module atom-package-deps. This module prompts the user to install split-diff. If user chooses "No", git-time-machine continues to function but no diffing occurs between the editors. Could also not prompt user and forcefully install, but figured I'd leave it as a choice.
Service consumption needs to occur in the main js file, so the service object is getting set on GitRevisionView from there as a means of passing the object. I didn't want to pass the service object through timeplot then to timeplot popup then to revision view. This is something that I can change if you have any preference on how that should be done.
This PR aims to consume
split-diff's new service API for diffing 2 editors.Benefits
git-time-machinethat was necessary to getsplit-diffworking.split-diffas a package so user can tweak settings via Atom settings view.split-diffwill stay up to date and user will get all new updates/bug fixes for it just like any other package.Things to note
atom-package-deps. This module prompts the user to installsplit-diff. If user chooses "No",git-time-machinecontinues to function but no diffing occurs between the editors. Could also not prompt user and forcefully install, but figured I'd leave it as a choice.