littlebee / git-time-machine

Atom package that allows you to travel back in commit history
MIT License
1.12k stars 36 forks source link

Encoding Issue when comparing commits #135

Open shoedler opened 6 years ago

shoedler commented 6 years ago

So I have an issue with encoding. I first thought the Problem would lie within the split-diff package. But that isn't the case.

I use Windows 1252 encoding. Now when I compare file A to file B directly - it doesn't show any differences (Well, since the filenames are different split-diff shows the whole file as a difference), since both files are Windows 1252 encoded and split-diff seems to use the encoding of the file. atomencodingissue0

But as soon as I compare for example the local version of file A to an older version of file A, it sees all umlauts ä,ö,ü as ? atomencodingissue1 Which obviously shows up as a difference.

Now to narrow the issue down, this is what happens when I compare commit to commit: atomencodingissue4 They show up identical - except the 2.

To me, it looks like, time-machine somehow shows commits in the wrong encoding type. I use Git for Windows and used TortoiseGit before Atom. I've diffed the same file with TortoiseGit and it shows it the right way. atomencodingissue3

Any ideas?