littlebee / git-time-machine

Atom package that allows you to travel back in commit history
MIT License
1.12k stars 36 forks source link

Uncaught TypeError: Cannot read property 'activateItem' of null #145

Open abcsds opened 5 years ago

abcsds commented 5 years ago

Hi, here are the steps to reproduce:

  1. Open a git diff view on a file.
  2. Close the diff version of the file and click on "Close without saving"

Atom: 1.38.2 x64 Electron: 4.2.5 OS: "Manjaro Linux" Thrown From: git-time-machine package 2.1.0

Stack Trace

Uncaught TypeError: Cannot read property 'activateItem' of null

At /home/abcsds/.dotfiles/atom/atom.symlink/packages/git-time-machine/lib/git-revision-view.coffee:47

TypeError: Cannot read property 'activateItem' of null
    at GitRevisionView.module.exports.GitRevisionView.activateTimeMachineEditorForEditor (/packages/git-time-machine/lib/git-revision-view.coffee:47:41)
    at /packages/git-time-machine/lib/git-revision-view.coffee:24:34
    at /packages/editor-stats/node_modules/underscore/underscore.js:768:19

Commands

     -5:52.6.0 command-palette:toggle (input.hidden-input)
  2x -5:42.4.0 git-diff:toggle-diff-list (input.hidden-input)
     -4:55.8.0 git-time-machine:toggle (input.hidden-input)
     -2:37.7.0 core:backspace (input.hidden-input)
     -2:35.3.0 intentions:highlight (input.hidden-input)
     -2:35.2.0 core:save (input.hidden-input)
     -0:56.4.0 core:backspace (input.hidden-input)
     -0:52.7.0 intentions:highlight (input.hidden-input)
     -0:52.2.0 editor:toggle-line-comments (input.hidden-input)
     -0:51.7.0 intentions:highlight (input.hidden-input)
     -0:51.6.0 core:save (input.hidden-input)
     -0:47.2.0 core:backspace (input.hidden-input)
     -0:46.6.0 autocomplete-plus:activate (atom-text-editor.editor.split-diff)
 14x -0:41.9.0 core:backspace (input.hidden-input)
     -0:32 intentions:highlight (input.hidden-input)
     -0:31.5.0 core:save (input.hidden-input)

Non-Core Packages

atom-beautify 0.33.4 
autocomplete-bibtex 1.2.1 
autocomplete-python 1.14.1 
busy-signal 2.0.1 
city-lights-syntax 1.1.8 
city-lights-ui 1.5.3 
color-picker 2.3.0 
docker 0.8.0 
editor-stats 0.17.0 
file-icons 2.1.33 
git-time-machine 2.1.0 
Hydrogen 2.10.0 
ink 0.10.10 
intentions 1.1.5 
jekyll 2.1.0 
julia-client 0.8.9 
language-csv 1.1.2 
language-julia 0.19.0 
language-latex 1.2.0 
language-matlab 0.2.1 
language-r 0.4.2 
language-viml 1.1.9 
latex-autocomplete 1.1.1 
latex-plus 0.9.1 
linter 2.3.0 
linter-flake8 2.4.0 
linter-julia 0.7.4 
linter-ui-default 1.7.1 
material-syntax 0.6.1 
pdf-view 0.71.0 
pigments 0.40.2 
python-tools 0.6.9 
set-syntax 0.4.0 
split-diff 1.4.0 
uber-juno 0.2.0 
miguelms95 commented 4 years ago

Same error here. Steps to reproduce:

  1. Open a git diff view on a file.
  2. Close the diff version of the file and click on "Close without saving"

Atom: 1.41.0 x64 Electron: 4.2.7 OS: Ubuntu 18.04.3 Thrown From: git-time-machine package 2.1.0

Stack Trace

Uncaught TypeError: Cannot read property 'activateItem' of null

At /home/miguel/.atom/packages/git-time-machine/lib/git-revision-view.coffee:47

TypeError: Cannot read property 'activateItem' of null
    at GitRevisionView.module.exports.GitRevisionView.activateTimeMachineEditorForEditor (/packages/git-time-machine/lib/git-revision-view.coffee:47:41)
    at /packages/git-time-machine/lib/git-revision-view.coffee:24:34
    at /packages/git-time-machine/node_modules/underscore/underscore.js:768:19

Commands

  3x -5:04.8.0 editor:select-to-beginning-of-word (input.hidden-input)
     -5:02.5.0 autocomplete-plus:confirm (input.hidden-input)
     -5:01.3.0 core:paste (input.hidden-input)
  3x -5:00.5.0 core:save (input.hidden-input)
     -4:28.9.0 editor:move-to-end-of-screen-line (input.hidden-input)
  4x -4:28.6.0 core:move-left (input.hidden-input)
     -4:27.8.0 editor:select-to-beginning-of-word (input.hidden-input)
     -4:26.3.0 core:save (input.hidden-input)
     -3:53 core:move-up (input.hidden-input)
     -3:52.6.0 editor:move-to-first-character-of-line (input.hidden-input)
     -3:52.4.0 core:delete (input.hidden-input)
     -3:51.2.0 editor:move-to-end-of-word (input.hidden-input)
     -3:50.2.0 editor:select-to-first-character-of-line (input.hidden-input)
     -3:47 core:move-down (input.hidden-input)
     -3:46.7.0 editor:move-to-end-of-screen-line (input.hidden-input)
 17x -1:27 git-time-machine:toggle (input.hidden-input)

Non-Core Packages

color-picker 2.3.0 
coverage 0.6.1 
git-time-machine 2.1.0 
goto-definition 1.3.4 
language-haml 0.32.1 
ruby-block 0.3.6 
split-diff 1.6.1 
symbols-tree-view 0.14.0 
tree-view-filter 0.5.5 
tree-view-git-status 1.5.2 
pmjohann commented 4 years ago

+1

flagsibh commented 4 years ago

Same here

RemekConsulting commented 3 years ago

Same here