search

littlebee / git-time-machine

Atom package that allows you to travel back in commit history
MIT License
1.12k stars 37 forks source link

Escape to close? #28

Closed bronson closed 6 years ago

bronson commented 8 years ago

I'd expect Esc to close the time machine panel, just like the find panel.

A close box would probably be nice too but I'm not sure where you'd put it.

Just a feature suggestion, feel free to close.

Great plugin!

littlebee commented 8 years ago

yeah, I keep going back and forth on escape to close. If a few people +1 it I'll do it. The hangup for me is that I sometimes / a lot of time have open the search and replace and when I open time machine I hit escape to close f&r to get move vert space.

I added a close button on the latest release.

nosamttimhcs commented 7 years ago

I use vim-mode-plus. Due to 15 years of using vim, I'm constantly reflexively hitting escape to ensure I'm in normal mode. If git-time-machine were to use escape to close, it would drive me nuts!

If you do decide to implement this requested feature, please consider not setting it as the default when the package upgrades and provide a config option to enable/disable it.

Thanks!