search

littlebee / git-time-machine

Atom package that allows you to travel back in commit history
MIT License
1.12k stars 36 forks source link

Deprecated selector in `git-time-machine/styles/git-time-machine.less` #92

Closed muhghazaliakbar closed 7 years ago

muhghazaliakbar commented 7 years ago

In git-time-machine/styles/git-time-machine.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

carrodher commented 7 years ago

Today I have the same issue

encodi commented 7 years ago

Same issue at atom 1.13.1 x64, macOS Sierra 10.12.3

littlebee commented 7 years ago

Thanks for letting me know. I looked in the less file for gtm and I don't see any uses of the two pseudo selectors. I also upgraded to Atom 1.13.1 (osx) and I'm not seeing either any exceptions or warnings in the console.

How does the issue manifest itself for you?

ShadowLNC commented 7 years ago

Hi, I have seen my deprecation count jump from 3 to 4 when running Git Time Machine: Toggle (I have bound a custom key Ctrl+G though I do not believe this would alter anything).

I also see the count jump from 4 to 6 when clicking a previous commit in order to open a diff. I believe these increases in count occur the first time such a selector is matched, as it would be inefficient for Deprecation Cop to pre-emptively match all stylesheets.

Win10 Pro, 64-bit

Running a grep in the git-time-machine package, as installed, reveals the following:

Scott@DARSANA MINGW64 ~/.atom/packages
$ grep --recursive "::shadow" git-time-machine/
git-time-machine/node_modules/split-diff/styles/split-diff.less:atom-text-editor, atom-text-editor::shadow {

So this may actually be part of split-diff, a dependency, and not part of git-time-machine itself.

My Deprecation Cop stats:

git-time-machine\styles\git-time-machine.less

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

littlebee commented 7 years ago

Thank you all for the reports and follow up information. This has been fixed in version 1.5.5 of git-time-machine.

muhghazaliakbar commented 7 years ago

cool :)