changing to add hash to activate - Githubissues

littlebits / cloud-client-api-http

Lightweight wrapper for littleBits Cloud HTTP API

GNU General Public License v3.0

32 stars 10 forks source link

changing to add hash to activate #15

Closed stresslimit closed 9 years ago

stresslimit commented 9 years ago

Update for new api interface add hash to activate

stresslimit commented 9 years ago

@jasonkuhrt i tested this out and it looks good, just need test to make more sense. I could keep it light and remove the failing test if you want.

jasonkuhrt commented 9 years ago

@houndci wtf machine, who invited you to the party?

@stresslimit Reviewing now.

jasonkuhrt commented 9 years ago

There are some other failing the tests that make no sense to me right now. Ugh. Still investigating.

jasonkuhrt commented 9 years ago

Currently failing cases:

[ ] PUT https://api-http.littlebitscloud.cc/devices/a1 (understood)
[ ] GET https://api-http.littlebitscloud.cc/subscriptions (not understood)
[ ] DELETE https://api-http.littlebitscloud.cc/subscriptions (not understood)

jasonkuhrt commented 9 years ago

Ok, this is a certified mess. I am really going down a rabbit hole that I don't have the time to resolve right now. The code-debt on our routes generation has come nipping at our heels. I will try another appraoch where we manually edit the routes file for now.

jasonkuhrt commented 9 years ago

@stresslimit Ok this is ready to go. We have debt across the board. This is scary stuff. I made an issue https://github.com/littlebitselectronics/cloud-platform/issues/32 that could represent a path forward. I'm really unhappy with the state of things.

stresslimit commented 9 years ago

Yeah I hear you @jasonkuhrt. We gots lots to clean. No lack of things to refactor based on our learnings :)