search

littlebizzy / hovercraft

No maintenance WordPress theme
https://hovercraft.vip
GNU General Public License v3.0
26 stars 3 forks source link

Mobile menu appears below WordPress admin bar #30

Closed siliconforks closed 1 year ago

siliconforks commented 1 year ago

When the user is logged in to WordPress, the mobile menu (id="myNav", with z-index 9999) appears below the WordPress admin bar (id="wpadminbar", with z-index 99999).

I would suggest increasing the z-index of the myNav element to something greater than 99999 so that it appears above the admin bar.

jessuppi commented 1 year ago

Thanks for your feedback @siliconforks

Okay I haven't tested but pushed z-index to 999999 let's see if that helps for now ;)

Ref: https://github.com/littlebizzy/hovercraft/commit/26dd5eef7835fc3d444e2198e7159c327ca90fb9

jessuppi commented 1 year ago

On a related note, the search box overlay is currently 99999 which is the same as WP admin bar... I have seen that value used on a few other projects for their search overlays, not sure why.

Might need to tweak both of these again later.

siliconforks commented 1 year ago

The mobile menu seems to be fixed now - it's now appearing above the admin bar.

I tried the full screen search and the search overlay is indeed below the admin bar, although that doesn't really matter much as the admin bar is not covering anything important.

I did notice an issue with the full screen search close button, but that is unrelated - I'll create another issue for that.