bbPress toolbar buttons disappeared

littlebizzy / hovercraft

No maintenance WordPress theme

https://hovercraft.vip

GNU General Public License v3.0

26 stars 3 forks source link

bbPress toolbar buttons disappeared #37

Open siliconforks opened 1 month ago

siliconforks commented 1 month ago

For an example, look at the form on https://slickstack.io/forum

bbpress

It looks like they disappeared with commit e2407ee9405f79899270765a5dc40117fb9add3d about a month ago.

jessuppi commented 1 month ago

Thank you @siliconforks

Hmm maybe it needs a fixed height or something? A lot of bbPress stuff is hardcoded and not easy to play with...

siliconforks commented 1 month ago

The bbPress default CSS is complicated, but it has a min-height value specified which seems to be necessary for the button to display correctly. Unfortunately e2407ee9405f79899270765a5dc40117fb9add3d added min-height: auto !important; which overrides this...

jessuppi commented 1 month ago

Looks like we can fix it with more specific CSS for .quicktags-toolbar input

Ref: https://github.com/littlebizzy/hovercraft/commit/84e84d1a8d9392d136684e640a2fd6ecf92cb8bb Ref: https://github.com/littlebizzy/hovercraft/commit/998dc769e594f70b9226dd2118a77be03e48e969

Not a fan of unnecessary !important but safer for now...