littlebizzy / slickstack

Lightning-fast WordPress on Nginx
https://slickstack.io
GNU General Public License v3.0
629 stars 112 forks source link

Production / Staging / Development drop-down malformed URLs #121

Closed Syncriix closed 2 years ago

Syncriix commented 2 years ago

Switching from Production to Staging and Development works as intended 133135683-9bb4fc93-103d-433b-a66a-02b35a5cddbe Switching from either Staging or Development to either availible options 133135796-9a31361b-853c-4082-a02a-a43bf17e15a4 results in malformed url's 133135838-478cd5c0-3588-4ec3-b6e9-2472eb71f174

jessuppi commented 2 years ago

Thanks for your feedback @Syncriix and sorry it took so long for us to respond here.

The code and functionality is now cleaned up a lot.

Tthe domain names are now inserted whenever ss-install-wordpress-mu-plugins is run to keep code simpler, and the PHP will preserve full URLs now which should make switching easier.

Ref: https://github.com/littlebizzy/slickstack/commit/25f637aaeaa50ab8b9de8ece6be823a5b99c5afb Ref: https://github.com/littlebizzy/slickstack/commit/94d76b4873726c6729dad049c84af2ad9a772db9

For example, if you're on this page:

https://staging.example.com/wp-admin/admin.php?page=slickstack

...the "Production" switch link will now link here:

https://www.example.com/wp-admin/admin.php?page=slickstack

...and so forth (production, staging, and dev). Much more predictable and useful functionality now, hopefully...

I will close this for now, but comments are welcome.

jessuppi commented 2 years ago

P.S. thanks @backamblock for the improvements in the meanwhile.