littlebizzy / slickstack

Lightning-fast WordPress on Nginx
https://slickstack.io
GNU General Public License v3.0
629 stars 112 forks source link

fix staging site crash because of tmp dir in mu-plugs #155

Closed backamblock closed 2 years ago

backamblock commented 2 years ago

damn you are too fast :D just made a screenshot but didn't get to upload itπŸ₯‡

jessuppi commented 2 years ago

Btw, I think there is a bug in ss-install-wordpress-mu-plugins when using custom plugins in ss-config that is causing that tmp folder to appear sometimes in the /mu-plugins/ folder, I haven't got around to checking it.

backamblock commented 2 years ago

hm maybe because you use regular rm without -r which will not delete directories

image

i'll send a commit shortly

jessuppi commented 2 years ago

rm is actually defined in ss-functions to behave like rm -rf

I've been in the process of converting these all to ss_rm instead after a guy on StackOverflow told me it was better practice.

backamblock commented 2 years ago

Pull request updated to use ss_rm πŸ‘πŸ»

image