search

littlebizzy / slickstack

Lightning-fast WordPress on Nginx
https://slickstack.io
GNU General Public License v3.0
638 stars 112 forks source link

Typo in ss-install and ss-check dos2unix file permissions #46

Closed Bronislawsky closed 4 years ago

Bronislawsky commented 4 years ago

Hello! ss-install:218:mkdir touch /var/www/meta/.ssh mkdir should not be there I beleive and ufw allow @SSH_PORT should be ufw allow $SSH_PORT no big beal also because users.rules override this

Also in ss-check dos2unix change de permission of ss and cron files I dont think its a big deal, but ss-perms and ss-check fight for their permissions :)

jessuppi commented 4 years ago

Thanks @Bronislawsky

ss-install is still pretty messy, I've saved it for last as far as optimization goes. Those typos that you mention have been fixed in the below commit:

Ref: https://github.com/littlebizzy/slickstack/commit/3aa1aa04ec70b2418bfa321291f9754827594f80

The perms conflicts have also been fixed in these 2 commits:

Ref: https://github.com/littlebizzy/slickstack/commit/0bb62b8e11a27ac0e243edd768ac17b1418fc064 Ref: https://github.com/littlebizzy/slickstack/commit/4a57e4c4ef170c83bcd032656f02962422103249