search

littlefs-project / littlefs

A little fail-safe filesystem designed for microcontrollers
BSD 3-Clause "New" or "Revised" License
4.9k stars 770 forks source link

Limit release script to only draft releases #967

Closed geky closed 2 months ago

geky commented 2 months ago

We probably always want a human involved in the final step of publishing a release. 1. To allow editing of the release notes before notifying users, and 2. to avoid any issues with rogue scripts (who doesn't want 1000 release notifications?).

Especially now that releases may trigger additional post-release scripts.

geky-bot commented 2 months ago
Tests passed ✓, Code: 17032 B (+0.0%), Stack: 1432 B (+0.0%), Structs: 812 B (+0.0%) | | Code | Stack | Structs | | Coverage | |:--|-----:|------:|--------:|:--|---------:| | Default | 17032 B (+0.0%) | 1432 B (+0.0%) | 812 B (+0.0%) | Lines | 2391/2571 lines (+0.0%) | | Readonly | 6190 B (+0.0%) | 448 B (+0.0%) | 812 B (+0.0%) | Branches | 1243/1582 branches (+0.0%) | | Threadsafe | 17896 B (+0.0%) | 1432 B (+0.0%) | 820 B (+0.0%) | | **Benchmarks** | | Multiversion | 17096 B (+0.0%) | 1432 B (+0.0%) | 816 B (+0.0%) | Readed | 29369693876 B (+0.0%) | | Migrate | 18728 B (+0.0%) | 1736 B (+0.0%) | 816 B (+0.0%) | Proged | 1482874766 B (+0.0%) | | Error-asserts | 17712 B (+0.0%) | 1424 B (+0.0%) | 812 B (+0.0%) | Erased | 1568888832 B (+0.0%) |
geky commented 2 months ago

Reverting/yanking - GitHub makes it way too difficult to notice pending draft releases.

  1. They create no notifications, even if they include an @geky
  2. They don't show up on the repo's homepage, you must navigate to the releases page
  3. It's difficult to notice when master/release are out of sync, there's nothing really relating the two on the repo's homepage
  4. You can't even subscribe to the release action, action notifications are all-or-none

This makes it very easy to forget pending releases generated ~an hour after merging PRs in less-frequented repos.

The alternative, marking generated releases as a "pre-release", seems to have the opposite problem: https://github.com/orgs/community/discussions/4993

There really needs to be some way to receive notifications on draft releases. Until then automatically releasing patch releases seems like the best compromise.