search

littleidiot40 / stac-collection-search

Free text keyword filtering at the STAC collection API
Apache License 2.0
0 stars 0 forks source link

Remarks #1

Open m-mohr opened 1 year ago

m-mohr commented 1 year ago

I'm a bit confused about this repo:

  1. Why is a STAC API extension in the STAC extensions org and not in the STAC API extensions org?
  2. Why not contribute to https://github.com/stac-api-extensions/collection-search ?
littleidiot40 commented 1 year ago

1: That might be our ignorance of the logistics of STAC extensions 2: We were unaware of that extension until recently. This is why we have reached out to you. We'd like to collaborate.

m-mohr commented 1 year ago

Ideally you'd open issues or pull requests at https://github.com/stac-api-extensions/collection-search so that we can discuss individual concerns better. It's hard for me to track what has changed in this repository.

By the way, the first point was my bad. I misread the repository location, sorry.

littleidiot40 commented 1 year ago

No problem. I think we need to come to an agreement on which repo to use as a base first before we start on PRs etc. Hence me reaching out to you via email. Yours was first, ours has more.

m-mohr commented 1 year ago

Ah, I just saw this e-mail now. It went to my university e-mail account, which I'm only checking when working for them actually.

I'd propose to use the other repo as this is already circulating in various areas and OGC API - Records is aware of it, which we aim to align with. As such the other repo mostly links to them as that avoids duplicating stuff and potentially getting out of sync.

I'd propose to split your additions into chunks with stuff that belongs together and then PR it so that we can go through the additions one by one with more folks. For example the search relation type seems to be in conflict with iteam search, something we need to discuss with the community.

m-mohr commented 1 year ago

I've updated the other collection search a bit to e.g. also include the q parameter, some other things I think are not very useful to include (e.g. externalId has no corresponding field in STAC). I'd encourage you to create issues and/or PRs against https://github.com/stac-api-extensions/collection-search. Ideally, we could then remove this extension in favor of a released version at https://github.com/stac-api-extensions/collection-search