Closed konkers closed 8 years ago
This seems pretty fine. Just a nit and LGTM.
Boo github drops comments from previous patch versions........
@konkers in github, comments are tied to a commit id, if u rebase, that id changes. if u know the sha1 u can still see the comments ;)
LGTM
rebased and pushed into mainline
See question on line 975.