search

littlekernel / lk

LK embedded kernel
MIT License
3.12k stars 613 forks source link

[stm32f0xx] Fix UART3/4 interrupts #231

Closed teisenbe closed 6 years ago

teisenbe commented 6 years ago

The IRQ handler was being misdefined, so the correct ISR was not being invoked.

teisenbe commented 6 years ago

Note that only one of UART3 or UART4 can be enabled at a time currently (there is a #if/#error check against it earlier in the file)

konkers commented 6 years ago

Lgtm

On Tue, May 8, 2018, 10:53 PM teisenbe notifications@github.com wrote:

Note that only one of UART3 or UART4 can be enabled at a time currently (there is a #if/#error check against it earlier in the file)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/littlekernel/lk/pull/231#issuecomment-387627995, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFjQpDZEj2e1WwGjYb0fA42SFLl8_fVks5twoRMgaJpZM4T3v8C .

tfmiltz commented 6 years ago

tyvm

travisg commented 6 years ago

for future reference, try to use the rebase button on these. The default merge button generates an extraneous merge commit which generally just messes up the history.

teisenbe commented 6 years ago

Oh whoops didn't even notice the different buttons. Will take a look in the future, sorry about that

On Wed, May 9, 2018, 01:15 Travis Geiselbrecht notifications@github.com wrote:

for future reference, try to use the rebase button on these. The default merge button generates an extraneous merge commit which generally just messes up the history.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/littlekernel/lk/pull/231#issuecomment-387659744, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIOP7j-UWzSJJ7u9IX98YIMhOfpSIbzks5twqWkgaJpZM4T3v8C .