search

littlekernel / lk

LK embedded kernel
MIT License
3.11k stars 613 forks source link

[dev][uart][pl011] Move to common driver #274

Open cleverca22 opened 3 years ago

cleverca22 commented 3 years ago

while merging the 2 drivers, i found a bug in the qemu variant of uart_getc that didnt reveal itself under qemu, and fixed it

i also added some code for the other 4 PL011's in the pi4, but no target for that yet

confirmed to function on both PROJECT=rpi2-test and scripts/do-qemuarm

travisg commented 3 years ago

Nice, looks like a good start. I'll do a review in a little bit but on pass, can you update the comment itself to include what it's doing? I'm not a fan at all of commit changes that just say it fixes a commit # without any context.

Something like [dev][uart][pl011] Move to common driver

And then a line or two describing what it did, including the bug fix and a mention that it fixes a bug #.

cleverca22 commented 3 years ago

i do have some further improvements to the uart driver on the vc4 fork, but trying to keep this commit clear of those, so its easier to see just the merging, and the improvements can come later