[gfx][colour] Separate surface manipulation functions from colour tra…

littlekernel / lk

LK embedded kernel

MIT License

3.15k stars 621 forks source link

[gfx][colour] Separate surface manipulation functions from colour tra… #82

Closed gkalsi closed 8 years ago

gkalsi commented 8 years ago

…nslation functions.

Reduce code duplication in the future. copyrect, fillrect, and putpixel are identical regardless of the colour representation (8bit rgb vs 8bit mono). Shifting the responsibility of flattening colours away from these functions.

travisg commented 8 years ago

LGTM

travisg commented 8 years ago

Also I saw what you did there.

gkalsi commented 8 years ago

Did I do something clever without realizing it? :stuck_out_tongue: