search

littlepea / django-editor

Allows pluggable WYSIWYG editors in django admin without hard dependencies
3 stars 2 forks source link

Advanced settings / Configurable editor #3

Open dokterbob opened 11 years ago

dokterbob commented 11 years ago

Patches allowing for extending editors and full configurability. Implementation of #1.

Patches of #2 are also in this pull request - but that should work out fine (they should simply disappear as soon as those are merged in - main reason is so we can split out eventual discussion).

littlepea commented 11 years ago

Hi,

This looks great! I'm going to test it with a real-world project this week and then merge.

Thanks!

dokterbob commented 11 years ago

@littlepea Have just added a model field in order to fully cover the API offered by TinyMCE (and make usage even easier). Let me know if this is something you do not want - in which case it is easily removed.

dokterbob commented 11 years ago

poke

dokterbob commented 11 years ago

@littlepea Another poke. :)

littlepea commented 11 years ago

@dokterbob Hi, sorry to keep you waiting, has been loaded at work... Will look into it this weekend I promise :)

dokterbob commented 10 years ago

Hey @littlepea, I see you are rather time constrained. :)

Perhaps it would be an idea to share maintainership somehow, so we can keep django-editor more up-to-date. That would make it a lot more likely for me (and other people) to actually start using it as a dependency in other projects.

Let me know what you think about it.

littlepea commented 10 years ago

Hi, I think it makes sense :)

How would it work, shall I give you commit permissions on the repo?

dokterbob commented 10 years ago

That, and perhaps also to the PyPI package.

Would also be great if we could review eachother's patches. So instead of pushing features straight to be master branch (which would be fine for bugfixes and such) we'd fire a pull request and assign the request to the other for a review (both contents and approach. This way we'll have an extra eye and both stay on the same page. Plus a code review never hurts (with newsletter I often have other people review and test my stuff).

littlepea commented 10 years ago

Sounds good. We could use feature branches then?

I've added you as collaborator, for pypi is your username "dokterbob"?