search

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

Bump minimum PHP version to 8.1 #114

Closed FelixJacobi closed 6 months ago

FelixJacobi commented 2 years ago

Should we do this? This would allow to this several good features to improve our code like property type hints, union types, enumerations and so on.

There are various major PHP libraries like Symfony already doing this.

SamuelWei commented 2 years ago

I support this idea

sualko commented 2 years ago

I would love to see support for PHP 7.4 until there is no more security support on November 28, 2022. From my pov we should support all currently maintained versions as an API lib. At least we should try to backport changes (if it's doable).

FelixJacobi commented 2 years ago

Would be fine for me. I would schedule a version 5.0 with the minimum requirement of PHP 7.4 in the near future. 6.0 in the direction of November/December with the minimum requirement of PHP 8.1. I would skip PHP 8.0 consciously as it feels like an incomplete version (as PHP 7.0 and 7.1 before). You don't gain much from requiring, only in conjunction with the features from PHP 8.1 it's sensible.

We can push in between another major version when we have more BC relevant changes before.

sualko commented 2 years ago

Sounds great for me. I will create some milestones and rename the title of this issue.