Closed FelixJacobi closed 2 years ago
I decided to remove the composer.lock
. It does not make sense to have it here for several reasons:
composer.lock
of the project is accounted.composer.lock
, which works for all PHP versions. We have relaxed deps, yes, but there are libraries used by us indirectly, which does not have a release which supports PHP 7.2 and 8.1 at the same time. Therefore, the CI for PHP 7.* begins to fail, when I am running composer require
on PHP 8.1 and vice versaWe're testing against the highest deps for all PHP versions and our oldest set supported (PHP 7.2 and lowest deps). So, I guess we are still safe without a lock file.
If we merge this, I would like to have a comment in the gitignore which explains the step or at least links back to this pr.
Sure, makes sense. Will do that.
I agree, we should remove the lock file. I reasearched a bit on recommendations/best practices, but didn't find it lot. However you can have a look at this comment: https://github.com/composer/composer/issues/2461#issuecomment-29282932
Most popular libraries I know also do not include the lock file.
This fixes compat with PHP 8.1: