Closed sualko closed 2 years ago
If someone has a running BBB 2.5 server, it would be great if this could be tested. I currently do not have access to one.
Got some test credentials from Fred and this new endpoint seams to work just fine :smile:
The CI for PHP 7.2 is failing due to php-cs-fixer crashing. Maybe you used PHP 7.3+ by accident or something like that?
The CI for PHP 7.2 is failing due to php-cs-fixer crashing. Maybe you used PHP 7.3+ by accident or something like that?
It's reporting some style issues. Not sure why.
It's reporting some style issues. Not sure why.
It's reporting
Files that were not fixed due to errors reported during linting before fixing:
But now I see why: The test case for InsertDocumentResponse
is wrongly named and uses the same name as the tested class.
The test case for InsertDocumentResponse is wrongly named and uses the same name as the tested class.
But this should produce an error for every php version and it still fails even after fixing the naming.
Ok, now I know what happened. I run cs-fixer before commiting my changes and since the filename was not like the class name, it changed the class name and also replaced the class with self inside the code. But I'm still unsure why it only fails for php 7.2.
Ok, now I know what happened. I run cs-fixer before commiting my changes and since the filename was not like the class name, it changed the class name and also replaced the class with self inside the code. But I'm still unsure why it only fails for php 7.2.
Yeah, quite mysterious ^^ . I thought, that CS Fixer probably is only running in the 7.2 job, but that's not the case.
This is a new endpoint introduced in BBB 2.5 (https://github.com/bigbluebutton/bigbluebutton/pull/14264).
I need to test it and write some tests for it before this can be merged.