search

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

add insertDocument endpoint #118

Closed sualko closed 2 years ago

sualko commented 2 years ago

This is a new endpoint introduced in BBB 2.5 (https://github.com/bigbluebutton/bigbluebutton/pull/14264).

I need to test it and write some tests for it before this can be merged.

sualko commented 2 years ago

If someone has a running BBB 2.5 server, it would be great if this could be tested. I currently do not have access to one.

sualko commented 2 years ago

Got some test credentials from Fred and this new endpoint seams to work just fine :smile:

FelixJacobi commented 2 years ago

The CI for PHP 7.2 is failing due to php-cs-fixer crashing. Maybe you used PHP 7.3+ by accident or something like that?

sualko commented 2 years ago

The CI for PHP 7.2 is failing due to php-cs-fixer crashing. Maybe you used PHP 7.3+ by accident or something like that?

It's reporting some style issues. Not sure why.

FelixJacobi commented 2 years ago

It's reporting some style issues. Not sure why.

It's reporting

Files that were not fixed due to errors reported during linting before fixing:

But now I see why: The test case for InsertDocumentResponse is wrongly named and uses the same name as the tested class.

sualko commented 2 years ago

The test case for InsertDocumentResponse is wrongly named and uses the same name as the tested class.

But this should produce an error for every php version and it still fails even after fixing the naming.

sualko commented 2 years ago

Ok, now I know what happened. I run cs-fixer before commiting my changes and since the filename was not like the class name, it changed the class name and also replaced the class with self inside the code. But I'm still unsure why it only fails for php 7.2.

FelixJacobi commented 2 years ago

Ok, now I know what happened. I run cs-fixer before commiting my changes and since the filename was not like the class name, it changed the class name and also replaced the class with self inside the code. But I'm still unsure why it only fails for php 7.2.

Yeah, quite mysterious ^^ . I thought, that CS Fixer probably is only running in the 7.2 job, but that's not the case.