search

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

Make master become 5.0 #143

Closed FelixJacobi closed 1 year ago

FelixJacobi commented 2 years ago

This merges the removal of all deprecations, removing unsupported PHP versions and BC breaks back to master.

Note: Must not be squashed on merge.

FelixJacobi commented 2 years ago

@sualko Could you disable the requirement of PHP 7.2 and 7.3 to pass? 😄

SamuelWei commented 2 years ago

@sualko Could you disable the requirement of PHP 7.2 and 7.3 to pass? 😄

Fixed

FelixJacobi commented 2 years ago

@sualko Could you disable the requirement of PHP 7.2 and 7.3 to pass? smile

Fixed

Hm, I thought only he could configure that. Did I miss something? Where is the setting?

SamuelWei commented 2 years ago

It was hidden in the protected branches setting

SamuelWei commented 2 years ago

@FelixJacobi Is it ready for review?

FelixJacobi commented 2 years ago

@FelixJacobi Is it ready for review?

Yes.

SamuelWei commented 2 years ago

Great, looking forward to 5.0 and 5.1, espacilly password deprecation. I'll do a review this arvo

SamuelWei commented 2 years ago

@FelixJacobi What about the deprecated consts in CreateMeetingParameters?

@FelixJacobi See https://github.com/littleredbutton/bigbluebutton-api-php/blob/62dcbe1dde719733fb7325de7c91bfe84871e416/src/Parameters/CreateMeetingParameters.php#L130 and the following lines Appart from that this PR can be merged

FelixJacobi commented 2 years ago

Yes, I am aware of it, but was quite busy the last days ^^ .

FelixJacobi commented 1 year ago

@FelixJacobi What about the deprecated consts in CreateMeetingParameters?

@SamuelWei Fixed.

SamuelWei commented 1 year ago

@FelixJacobi @sualko Should be do a 5.0 release before merging as planed in: https://github.com/littleredbutton/bigbluebutton-api-php/issues/137 ?

SamuelWei commented 1 year ago

@FelixJacobi Shouldn't we resolve #120 first?

FelixJacobi commented 1 year ago

@FelixJacobi Shouldn't we resolve #120 first?

Yes, it's planned to do that after that PR separately as this will change a lot of lines in the whole codebase.

FelixJacobi commented 1 year ago

@FelixJacobi @sualko Should be do a 5.0 release before merging as planed in: https://github.com/littleredbutton/bigbluebutton-api-php/issues/137 ?

Not needed. The checklist there is not strictly chronically. For 4.3, we already have a 4.3 branch.