Closed FelixJacobi closed 1 year ago
@sualko Could you disable the requirement of PHP 7.2 and 7.3 to pass? 😄
@sualko Could you disable the requirement of PHP 7.2 and 7.3 to pass? 😄
Fixed
@sualko Could you disable the requirement of PHP 7.2 and 7.3 to pass? smile
Fixed
Hm, I thought only he could configure that. Did I miss something? Where is the setting?
It was hidden in the protected branches setting
@FelixJacobi Is it ready for review?
@FelixJacobi Is it ready for review?
Yes.
Great, looking forward to 5.0 and 5.1, espacilly password deprecation. I'll do a review this arvo
@FelixJacobi What about the deprecated consts in CreateMeetingParameters?
@FelixJacobi See https://github.com/littleredbutton/bigbluebutton-api-php/blob/62dcbe1dde719733fb7325de7c91bfe84871e416/src/Parameters/CreateMeetingParameters.php#L130 and the following lines Appart from that this PR can be merged
Yes, I am aware of it, but was quite busy the last days ^^ .
@FelixJacobi What about the deprecated consts in CreateMeetingParameters?
@SamuelWei Fixed.
@FelixJacobi @sualko Should be do a 5.0 release before merging as planed in: https://github.com/littleredbutton/bigbluebutton-api-php/issues/137 ?
@FelixJacobi Shouldn't we resolve #120 first?
@FelixJacobi Shouldn't we resolve #120 first?
Yes, it's planned to do that after that PR separately as this will change a lot of lines in the whole codebase.
@FelixJacobi @sualko Should be do a 5.0 release before merging as planed in: https://github.com/littleredbutton/bigbluebutton-api-php/issues/137 ?
Not needed. The checklist there is not strictly chronically. For 4.3, we already have a 4.3 branch.
This merges the removal of all deprecations, removing unsupported PHP versions and BC breaks back to master.
Note: Must not be squashed on merge.