Support new checksum algorithm (sha256)

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton

GNU Lesser General Public License v3.0

25 stars 12 forks source link

Closed znerol closed 10 months ago

znerol commented 1 year ago

BBB is about to switch form SHA1 to SHA256 as the checksum algorithm (see bigbluebutton/bigbluebutton#15684).

Hence, this library should allow its clients to specify which algorithm to use.

SamuelWei commented 1 year ago

Yes, I noticed this change and how this will become very important soon.

FelixJacobi commented 1 year ago

Adding to 5.1, as 5.0 cannot get new features due to being deprecation-free release of 4.3.

znerol commented 1 year ago

Should one wait for #145 to be merged before opening a PR?

SamuelWei commented 1 year ago

Adding this feature brings a few design decisions with it.

Some possible implementation/design ideas:

Adding hash algorithm to the constructor as the fourth argument behind the transport interface (PR #147) [Non-BC]
Just add hash algorithm as a fluent setter [Non-BC]
Replace base url and secret in constructor with object of a seperate class [BC]
Remove base url and secret from constructor and replace with fluent setters [BC]

@FelixJacobi @sualko What do you think would be best future proof.