Improve code quality - Githubissues

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton

GNU Lesser General Public License v3.0

24 stars 12 forks source link

Improve code quality #177

Open FelixJacobi opened 4 months ago

FelixJacobi commented 4 months ago

Strict types, where missing (could break compatibility)
Return type hints, where still missing (must be done in a major release, since it breaks compatibility unlike parameter type hints)

FelixJacobi commented 3 months ago

Rector?

SamuelWei commented 3 months ago

Can psalm also do this, as we already have it installed

FelixJacobi commented 3 months ago

Yes, it can partly, but it's mainly focused on missing types in code. Rector is more focused on modernizing code in general. Using IServ-GmbH/cotor: The Composer Tools Installer we can just install it and play it around with it ^^ . I will work on this in the next days.