search

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

- getting the internal meeting-id from the meeting of the recording #208

Closed marineusde closed 1 month ago

marineusde commented 2 months ago

If the user or a plugin create more than 1 meeting with the same meetingId, we got records from the false meeting. So I have to check the "internal Meeting-ID" of the recording with the meeting after getting from the api.

This merge request extends the Record class with the "internalMeetingId" of the recording.

FelixJacobi commented 2 months ago

Hello @marineusde! 👋🏼

Thank you for your contribution. Could please rebase your PR against master which recently became 6.x? We introduced stricter coding rules there, tools/rector process src/ should help you to apply them correctly. Also, could you please add your new method to the respective test please?

Thanks!

marineusde commented 2 months ago

Hello @marineusde! 👋🏼

Thank you for your contribution. Could please rebase your PR against master which recently became 6.x? We introduced stricter coding rules there, tools/rector process src/ should help you to apply them correctly. Also, could you please add your new method to the respective test please?

Thanks!

Oh, 6.x was released :O

First I will test the new version in our project, then I will rebase the code to this.

marineusde commented 2 months ago

@FelixJacobi I rebased now the branch

FelixJacobi commented 2 months ago

@FelixJacobi I rebased now the branch

LGTM, thanks. Could you extend the tests please. Then, we can merge, I think ;) .

marineusde commented 2 months ago

@FelixJacobi I rebased now the branch

LGTM, thanks. Could you extend the tests please. Then, we can merge, I think ;) .

done

Is it possible to release a new version 6.1 in the next days? Its a very huge problem for us in the moment, that we get the "wrong" recordings for a meeting, cause ILIAS- and Moodle-Plugins reuse the name for their meetingId in different meetings.

If you want, I can help you with the other issues for the version 6.2 ;)