search

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

getDefaultConfigXML fail on BBB 2.3 #73

Closed SamuelWei closed 3 years ago

SamuelWei commented 3 years ago

Requesting getDefaultConfigXML on BBB 2.3 will result in an error, see https://github.com/bigbluebutton/bigbluebutton/issues/12408

We should either remove this from the api or have an .env value to disable the feature, so tests no longer fail

sualko commented 3 years ago

For documentation: See https://github.com/bigbluebutton/bigbluebutton/pull/12432

Removes obsolete config.xml references - remnant of the Flash client, not supported since BBB 2.2.x-2.3.x

FelixJacobi commented 3 years ago

I guess we should provide a proper deprecation notice. Although the calls does not have any effect at all anymore it is probably still called inside of projects which using this library.

Deprecating in 4.0 and remove in 4.1? (as we currently did not have any strict roadmap like Symfony regarding Major and minor versions (only the first one allowed to remove deprecated code) as far as I can see?)

Regarding tests: I would them to a specific @group which is excluded by default from running.

FelixJacobi commented 3 years ago

See #77.

sualko commented 3 years ago

Deprecating in 4.0 and remove in 4.1?

Sounds like a good idea, since we have a few deprecated methods in the next release.

Regarding tests: I would them to a specific @group which is excluded by default from running.

:+1: