search

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

http_build_query: Use RFC 3986 instead of RFC 1738 to improve interoperability with other libraries (fixes #74) #75

Closed FelixJacobi closed 3 years ago

FelixJacobi commented 3 years ago

First seen on interacting with Symfony HTTP client.

SamuelWei commented 3 years ago

What about $queries['configXML'] = urlencode($this->rawXml->asXML()); in src/Parameters/SetConfigXMLParameters.php ? I'm not to worried about it, as (see #73) in BBB 2.3 the whole configXML API endpoints are removed

There are also a few urlencodes in tests/unit/Parameters/CreateMeetingParametersTest.php, it wouldn't make a difference there, but it could be done for conistency

FelixJacobi commented 3 years ago

What about $queries['configXML'] = urlencode($this->rawXml->asXML()); in src/Parameters/SetConfigXMLParameters.php ?

Hm, interesting. I am not familiar with the configXML stuff as it was only relevant for the Flash client AFAIK which I never worked with. But I guess its fine to change it too although http_build_query already should do the job in theory.

FelixJacobi commented 3 years ago

What about $queries['configXML'] = urlencode($this->rawXml->asXML()); in src/Parameters/SetConfigXMLParameters.php ? I'm not to worried about it, as (see #73) in BBB 2.3 the whole configXML API endpoints are removed

There are also a few urlencodes in tests/unit/Parameters/CreateMeetingParametersTest.php, it wouldn't make a difference there, but it could be done for conistency

Addressed.

SamuelWei commented 3 years ago

What about $queries['configXML'] = urlencode($this->rawXml->asXML()); in src/Parameters/SetConfigXMLParameters.php ? I'm not to worried about it, as (see #73) in BBB 2.3 the whole configXML API endpoints are removed There are also a few urlencodes in tests/unit/Parameters/CreateMeetingParametersTest.php, it wouldn't make a difference there, but it could be done for conistency

Addressed.

Do you also change it in CreateMeetingParametersTest.php or should we merge?

FelixJacobi commented 3 years ago

What about $queries['configXML'] = urlencode($this->rawXml->asXML()); in src/Parameters/SetConfigXMLParameters.php ? I'm not to worried about it, as (see #73) in BBB 2.3 the whole configXML API endpoints are removed There are also a few urlencodes in tests/unit/Parameters/CreateMeetingParametersTest.php, it wouldn't make a difference there, but it could be done for conistency

Addressed.

Do you also change it in CreateMeetingParametersTest.php or should we merge?

My fault, forgot to include the changes in the commit 😄 . Just a second...

FelixJacobi commented 3 years ago

What about $queries['configXML'] = urlencode($this->rawXml->asXML()); in src/Parameters/SetConfigXMLParameters.php ? I'm not to worried about it, as (see #73) in BBB 2.3 the whole configXML API endpoints are removed There are also a few urlencodes in tests/unit/Parameters/CreateMeetingParametersTest.php, it wouldn't make a difference there, but it could be done for conistency

Addressed.

Do you also change it in CreateMeetingParametersTest.php or should we merge?

My fault, forgot to include the changes in the commit smile . Just a second...

Check.