search

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

Fixed cookie extraction in CurlTransport in PHP 8 (fixes #76) #78

Closed FelixJacobi closed 3 years ago

FelixJacobi commented 3 years ago

It seems that the format of the cookie jar of cURL cookie jar changed and so the regular expression no longer matches correctly. Good opportunity to get rid of the temporary file approach and remove almost all environment dependencies (here: writable file system).

This is a bigger change, but luckily we have integration tests here.

sualko commented 3 years ago

can we merge this?

SamuelWei commented 3 years ago

Is there a test for getHeadersAndContentFromCurlHandle ?

FelixJacobi commented 3 years ago

Is there a test for getHeadersAndContentFromCurlHandle ?

It should be covered by CurlTransportTest, but I forgot to update @covers. We probably should move the method into the CurlTransport to make things clear here as it is an implementation detail.

FelixJacobi commented 3 years ago

Hm, to make Coveralls happy we must run CurlTransportTest in workflows, I guess. This should not be a problem. I would split the integration suite into integration (for CurlTransport, to make clear it isn't a real unit test due to environment dependencies) and functional (for the tests against real BBB).

FelixJacobi commented 3 years ago

Hm, to make Coveralls happy we must run CurlTransportTest in workflows, I guess. This should not be a problem. I would split the integration suite into integration (for CurlTransport, to make clear it isn't a real unit test due to environment dependencies) and functional (for the tests against real BBB).

See #90. Will rebase this PR. Coveralls should be fixed then.