search

littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

added release action workflow #94

Closed jibon57 closed 2 years ago

jibon57 commented 3 years ago

This will add ready to use library with every release. This will trigger when you will publish new release.

sualko commented 3 years ago

Thanks for your contribution.

Since this library does not have any dependencies (except some external once), what is the point of building a release like that?

In the past we just created a release here on Github which gets automatically pushed to packagist, which worked fine. This process could maybe optimized via a .gitattributes file to exclude e.g. the .github folder. I will open a pr for that.

jibon57 commented 3 years ago

@sualko thanks for reply. This is ready to use library with auto loader included. User can just download & start using. No need to run any command or composer. Example: https://github.com/mynaparrot/bigbluebutton-api-php/releases/tag/3.3.1 This PR was supporting for my blog post Connect with BigBlueButton in easy 2 steps using PHP

sualko commented 3 years ago

Thanks for your explanation. For me it's a nice addition. Other thoughts?

FelixJacobi commented 3 years ago

For me, it's fine to support such a thing.

Although I see only a few special use cases. Normally, you should use Composer e.g. to get updates of our dependencies as soon as possible. If you would use the zip ball, you won't get any updates of them for e.g. nearly six months if we don't create new releases.

For simply testing out the library, it is a good approach but I wouldn't recommend this for production usage for the reasons described. If we can add a clarification somewhere, I am fine with accepting that here.

FelixJacobi commented 2 years ago

Closed due to missing recent activity. Feel free to request a reopening or submit a new PR.