littleredbutton / bigbluebutton-api-php

Unofficial (but better) PHP API for @BigBlueButton
GNU Lesser General Public License v3.0
25 stars 12 forks source link

JoinMeetingParameters: Fixed typo in magic method annotation #97

Closed FelixJacobi closed 3 years ago

FelixJacobi commented 3 years ago

The property is named joinViaHtml5, calling setJoinViaHtml causes an BadMethodCallException. I would schedule this change for 4.0.1 a ka a bug fix release.

FelixJacobi commented 3 years ago

@sualko As I am not familiar with the flow here: To create a new bugfix release containing this change, is it enough to create a new release here on GitHub to publish it also on Packagist? A colleague of me asked for this fix and I guess, we should publish it soon.

sualko commented 3 years ago

Yes that's enough. Just go ahead and create a new release.