type imprecision in class CreateMeetingParameters

[frederic100]

Hello, I think there may be a type imprecision in class CreateMeetingParameters for method:

    /**
     * @param      $nameOrUrl
     * @param null $content
     * @param null $filename
     *
     * @return CreateMeetingParameters
     */
    public function addPresentation($nameOrUrl, $content = null, $filename = null)

I propose the following code:

    /**
     * @param string $nameOrUrl
     * @param string|null $content
     * @param string|null $filename
     *
     * @return CreateMeetingParameters
     */
    public function addPresentation(string $nameOrUrl, ?string $content = null, ?string $filename = null): CreateMeetingParameters

[SamuelWei]

Hi @frederic100,

this would be fixed in #82 (https://github.com/littleredbutton/bigbluebutton-api-php/pull/82/files#diff-3648cfeb8ac72274caf37fc5d73d88ca87af27eb56003afb681192fb2af46096L597).

@FelixJacobi What is the status of #82?

Greetings, Samuel

[FelixJacobi]

Hi everyone,

Sorry for the late response.

Regarding #82: Nothing more happened yet as I am currently bound to other projects and we need additional work a ka better test coverage before continuing there.

In my opinion, #82 is more a code modernization (using native PHP types) than a bug fix and is therefore scheduled for release 4.1, which don't have a release horizon yet.

I would be fine with accepting the doc block change as a bug fix. @frederic100 Feel free to submit it as a PR, if you are familiar with that. Please note that the PR should be targeted to the 4.0 branch as master will become 4.1.

[sualko]

Since the pr is merged, this issue has been fixed.