search

littleredbutton / cloud_bbb

@bigbluebutton integration for @nextcloud
GNU Affero General Public License v3.0
103 stars 43 forks source link

Add option to promote guests to moderators #151

Open jacotec opened 3 years ago

jacotec commented 3 years ago

Describe the bug When I start a conference via Greenlight I have the option as the room owner / moderator to promote any other user in the conference also to moderator status (Click on the user --> Make this user a moderator).

grafik

Also you can take this back and degrade the user back to "normal":

grafik

These options are missing in rooms which are opened via Nextcloud.

To Reproduce Steps to reproduce the behavior:

  1. Start your own room
  2. Connect as a guest user with a second device
  3. Accept the guest user
  4. The option to make the new guest user a moderator is missing from the menu

Expected behavior The menu option should be available

Screenshots See above

System (please complete the following information):

sualko commented 3 years ago

I have no idea why this option is not visible with Nextcloud, but it could be related to the guest parameter. Can you try to remove the following line and try again?

https://github.com/sualko/cloud_bbb/blob/master/lib/BigBlueButton/API.php#L90

jacotec commented 3 years ago

@sualko Thanks Klaus, good idea! This solves it! :-)

Is there any unwanted side effect by removing this line?

sualko commented 3 years ago

Thanks Klaus, good idea! This solves it! :-)

Good and bad. Seams like an issue, or an undocumented feature, in BBB. In the documentation there is only this:

Set to “true” to indicate that the user is a guest, otherwise do NOT send this parameter.

For me it's a nice feature to see if someone is connected with his Nextcloud account, because in this case I can trust e.g. the name.

Can you open an issue at BBB? Maybe they can contribute some background information.

jacotec commented 3 years ago

OK ... I've tested a bit with this and read the BBB specs.

Removing this line does not flag the guest user officially as a "guest". He's like a normal member then. Guests cannot be promoted to be a moderator, except in BBB 2.3 when the global parameter "authenticatedGuest=false" is set. But this takes away a couple of other functions as well.

Greenlight seems to treat the users joining via link as normal users, hence they can be promoted.

There are already some discussions at BBB: https://github.com/bigbluebutton/bigbluebutton/pull/11215 https://github.com/bigbluebutton/bigbluebutton/issues/9644

So it's not an issue, basically it's a security design to prevent guests being promoted (what happened in a German school a few weeks ago in a Jitsi conference, where the teacher was kicked by a promoted guest who then played a porn movie).

In some rooms on the other hand it's a great feature to have the ability to promote guests. Also your idea to see NC members is absolutely fine.

Setting "authenticatedGuest=false" in BBB is not a good solution as it's global and costs a couple of features.

I'd like to turn this into a feature request then: Making it a checkbox "Disable guest feature" in the room configuration would be perfect as this can be selected per room then by the room admin.

What do you think?

sualko commented 3 years ago

Making it a checkbox "Disable guest feature" in the room configuration would be perfect as this can be selected per room then by the room admin.

Putting the normal user into charge of security related settings is always an issue. I know from multiple administrators that the current set of options is already to much and they have concerns that people configure a "broken" room. Since I don't see the use case to promote guests to moderators, this feature is not on my short list.