search

littleredbutton / cloud_bbb

@bigbluebutton integration for @nextcloud
GNU Affero General Public License v3.0
103 stars 42 forks source link

Restriction settings as admin do not show all groups #87

Open agru opened 4 years ago

agru commented 4 years ago

In the admin settings for this app it is possible to set different restrictions for different groups of users. But in the input-field, where groups can be selected, only a small subset of our groups can be found. Most groups do not show up there!?

Steps to reproduce the behavior:

  1. Go to 'Settings'
  2. Click on 'Further Settings' (in German 'Zusätzliche Einstellungen) at the end on the left-hand menu
  3. Scroll down to 'BigBlueButton'-Settings, 'Restrictions', 'Group name' and try to find group
  4. See that not all groups are available. When one of the affected groups is entered by its first letters, 'Keine Übereinstimmungen" (no matches) is shown. Even if you enter the complete group-name, it is not accepted manually.

Expected behavior I would like to be able to enter any group of users we have defined

System (please complete the following information):

Javascript log: {ocs: {meta: {status: "ok", statuscode: 100, message: "OK", totalitems: "", itemsperpage: ""},…}} ocs: {meta: {status: "ok", statuscode: 100, message: "OK", totalitems: "", itemsperpage: ""},…} data: {exact: {users: [], groups: [], remotes: [], remote_groups: [], emails: [], circles: [], rooms: []},…} circles: [] emails: [] exact: {users: [], groups: [], remotes: [], remote_groups: [], emails: [], circles: [], rooms: []} groups: [] lookup: [] lookupEnabled: true remote_groups: [] remotes: [] rooms: [] users: [] meta: {status: "ok", statuscode: 100, message: "OK", totalitems: "", itemsperpage: ""} itemsperpage: "" message: "OK" status: "ok" statuscode: 100 totalitems: ""

sualko commented 4 years ago

I guess you have restricted sharing to groups which you are part of. As a workaround you can remove that restriction (admin share settings), add more restrictions to the bbb app and enable that option again. To fix this issue durably you would need to create an own endpoint to search for specific groups, or serve a complete list and filter it completely client side.

agru commented 4 years ago

That is indeed the situation at our Nextcloud. Due to data protection regulations we have restricted the sharing to groups where the users are part of. Your suggested workaround works.

I am not deep into Nextcloud, but why can I find every group of our server when I switch on to restrict the BBB-app to groups? There, the restriction of only sharing to groups that the users are part of, does not affect the available groups. In the settings, that are also only available to admin accounts, the restriction affects the available groups. Probably I do not know enough how this works, so I just thought I'm gonna ask ;-)

sualko commented 4 years ago

There, the restriction of only sharing to groups that the users are part of, does not affect the available groups.

Sorry, I don't exactly understand what you mean. Can you explain it in more detail?

agru commented 4 years ago

If someone is installing the BBB app in Nextcloud, it is one of the apps that allows to restrict the usage / the availability of this app only to specified groups. This setting is directly available for the admin of Nextlcoud under the menu item "Apps" (where you also install, activate, deactive apps on the server). If you click on the app there, on the right hand side you get more informations about the app, but you also have a check box to restrict this app to selected groups only.

Then, under the menu item settings -> further settings (Weitere Einstellungen) there are configuration options that your app offers. There again, I can select groups for which I want to have settings that differ from other groups.

While I find every group available in the system for the situation described in the 1st paragraph, independent whether I am member of that group, I only find my own groups for the situation described in the 2nd paragraph.

That's what I meant. Why is it possible in case 1, not in case 2. In both situations I am admin.

sualko commented 4 years ago

Why is it possible in case 1, not in case 2

Because in case 2 we are using the official share api so we don't have to rewrite the whole logic, but as mentioned we probably have to do it, to proper fix this issue.

nomisge commented 3 years ago

For me it doesn't work with groups created by LDAP. I have not restricted sharing to groups. Any updates on the issue?

EDIT: It does work if I temporarily add a Ldap user (who is in the target group) to the admin group. My non ldap admin account still cannot set the target-group, cause i can't add it to ldap-groups.

an0nz commented 2 years ago

I have just run into this problem also. Based on my tests the following settings must be applied so that groups search works for BBB restrictions

With those settings set I was able to add any groups needed to the restrictions and then revert my share settings back to what we need.

This bug took me a while to work out which sharing settings needed to be enabled as unlike the OP I had no groups showing in the search due to our sharing settings, hopefully this helps someone else and the bug gets fixed or at least well documented.